Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider sea surface currents in air-sea flux calculation for ufs atmosphere-ocean coupling #2104

Merged
merged 24 commits into from
Feb 1, 2024

Conversation

binli2337
Copy link
Contributor

@binli2337 binli2337 commented Jan 19, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
  • Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

This PR adds capability of considering sea surface current's impact on air-sea flux calculation for atmosphere-ocean coupling.

Commit Message

Enable the capability of considering sea surface current's impact on air-sea flux calculation for atmosphere-ocean coupling. A namelist option is added to control whether or not to use this feature (default is off). Fixes #1975

Co-authored by: @binli2337, @BinLiu-NOAA, @WeiguoWang-NOAA, @BijuThomas-NOAA, @hyunsookkim-NOAA, @XuLi-NOAA, @MariaAristizabal-NOAA, @JohnSteffen-NOAA

Priority

  • Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
  • High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
    • Needed for HAFSv2 upgrade code freeze
  • Normal

Blocking Dependencies

Git Issues Fixed By This PR

Changes

Subcomponent (with links)

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
FAILED REGRESSION TESTS

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@BinLiu-NOAA BinLiu-NOAA changed the title Consider sea surface ocean currents in the air-sea flux calculation Consider sea surface currents in air-sea flux calculation for ufs atmosphere-ocean coupling Jan 19, 2024
@BinLiu-NOAA BinLiu-NOAA added enhancement New feature or request No Baseline Change No Baseline Change labels Jan 19, 2024
@jkbk2004
Copy link
Collaborator

@binli2337 can you sync up branches? As we discussed, we will try to combine #2098 to this PR from physics PR level. I am moving to ufs-community/ccpp-physics#155 to follow up there.

@BinLiu-NOAA
Copy link
Contributor

@binli2337 can you sync up branches? As we discussed, we will try to combine #2098 to this PR from physics PR level. I am moving to ufs-community/ccpp-physics#155 to follow up there.

@jkbk2004 This PR branch and all its submodules have been synced with their corresponding ufs-weather-model develop branch. Thanks!

@BinLiu-NOAA
Copy link
Contributor

A quick follow-up is that, the full RT set went through on WCOSS2 successfully, confirming no answer changing for the baseline.

Meanwhile, a note is that, the gnv1_nested_intel test failed in the first try during result checking/comparing against baseline, however the second try of the gnv1_nested_intel test succeeded without issues. Another note is that, I encountered the similar issue (first try failed, second run succeeded) for this gnv1_nested_intel test while testing another PR branch.

With that, I think this PR/branch is ready to proceed for next steps. Thanks!

@DeniseWorthen
Copy link
Collaborator

@BinLiu-NOAA We need Logs from Hera committed to the PR branch before proceeding (Hera adds GNU compile/test).

@zach1221
Copy link
Collaborator

@BinLiu-NOAA We need Logs from Hera committed to the PR branch before proceeding (Hera adds GNU compile/test).

@DeniseWorthen I can run them, if needed to move forward. My ecflow seems to work ok on hera now.

@BinLiu-NOAA
Copy link
Contributor

@BinLiu-NOAA We need Logs from Hera committed to the PR branch before proceeding (Hera adds GNU compile/test).

@DeniseWorthen I can run them, if needed to move forward. My ecflow seems to work ok on hera now.

Thanks, @zach1221!

@binli2337
Copy link
Contributor Author

@DeniseWorthen Have you started the runs? I can do it.

@DeniseWorthen
Copy link
Collaborator

No, I have not started RTs (didn't think I needed to).

@BinLiu-NOAA
Copy link
Contributor

@binli2337 and @DeniseWorthen, I just checked. And @zach1221 is currently running RTs on Hera for this PR. Thanks!

@zach1221
Copy link
Collaborator

@binli2337 and @DeniseWorthen, I just checked. And @zach1221 is currently running RTs on Hera for this PR. Thanks!

Yes, I have them going. A little more than halfway there.

@zach1221
Copy link
Collaborator

@binli2337 fyi, we're going to work PR #2098 currently and will work this one afterwards.

@zach1221
Copy link
Collaborator

zach1221 commented Jan 30, 2024

Hera logs attached. No changes.

RegressionTests_hera.log

@zach1221
Copy link
Collaborator

@binli2337 can you please sync up your branch here? We'll begin testing against this PR next.

@zach1221 zach1221 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Jan 31, 2024
@BinLiu-NOAA
Copy link
Contributor

@zach1221, wondering if this PR is ready for the final RT processing. Also, feel free to let us know if help is needed to run the full set of RTs on WCOSS2. Thanks!

@zach1221
Copy link
Collaborator

zach1221 commented Feb 1, 2024

@zach1221, wondering if this PR is ready for the final RT processing. Also, feel free to let us know if help is needed to run the full set of RTs on WCOSS2. Thanks!

Hi, @BinLiu-NOAA sorry for the late reply. Yes, the tests are running. We're working to get them finished as soon as possible. Brian should be taking care of WCOSS tests.

@FernandoAndrade-NOAA
Copy link
Collaborator

FernandoAndrade-NOAA commented Feb 1, 2024

In addition to cpld_debug_gfsv17_intel, the hafs_regional_atm_ocn_wav_intel test has also failed with a timeout on Jet. However, it should be noted the failure was properly reported on the test summary at the end.

@BinLiu-NOAA
Copy link
Contributor

Much appreciated, @zach1221, @FernandoAndrade-NOAA, @BrianCurtis-NOAA! Hopefully, the RTs will go through smoothly. Thanks!

@zach1221
Copy link
Collaborator

zach1221 commented Feb 1, 2024

Regression testing is complete. We can proceed with the merging process on ccpp-physics and cubed-sphere.
@binli2337 @BinLiu-NOAA

@DeniseWorthen
Copy link
Collaborator

@binli2337 cmeps is merged 8cd4a32

@zach1221
Copy link
Collaborator

zach1221 commented Feb 1, 2024

@binli2337 fv3atm is merged now as well. NOAA-EMC/fv3atm@8db821c

@binli2337
Copy link
Contributor Author

@zach1221 I will merge FV3 now.

@binli2337
Copy link
Contributor Author

It is ready for review. Thanks!

@zach1221 zach1221 merged commit db98161 into ufs-community:develop Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
8 participants